Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix completion adds superfluous equal to field_name #596

Merged

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Dec 6, 2022

Closes: #580

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 73.54% // Head: 73.45% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (00ec7cb) compared to base (55fb0b6).
Patch coverage: 73.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
- Coverage   73.54%   73.45%   -0.10%     
==========================================
  Files          23       23              
  Lines        1739     1748       +9     
  Branches      532      539       +7     
==========================================
+ Hits         1279     1284       +5     
  Misses        186      186              
- Partials      274      278       +4     
Impacted Files Coverage Δ
...koxudaxi/pydantic/PydanticCompletionContributor.kt 85.11% <73.33%> (-1.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koxudaxi koxudaxi merged commit 4dfbe34 into master Dec 9, 2022
@koxudaxi koxudaxi deleted the fix_completion_adds_superfluous_equal_to_field_name branch December 9, 2022 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion adds superfluous "=" to field name
1 participant